Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add design doc Architecture Of Distributed Storage And Transaction #3655

Merged
merged 50 commits into from
Dec 20, 2021
Merged

Add design doc Architecture Of Distributed Storage And Transaction #3655

merged 50 commits into from
Dec 20, 2021

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Dec 15, 2021 •
edited
Loading

Signed-off-by: Zhigao Tong [email protected]

What problem does this PR solve?

What is changed and how it works?

  • Add design doc Architecture Of Distributed Storage And Transaction

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 15, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 15, 2021
@fuzhe1989
Copy link
Contributor

wow, amazing!

@solotzg
Copy link
Contributor Author

solotzg commented Dec 15, 2021

wow, amazing!

PTAL

@solotzg solotzg requested a review from fuzhe1989 December 15, 2021 15:10
@solotzg
update 1
15d6777 
Signed-off-by: Zhigao Tong <[email protected]>
@solotzg
update 2
0286001 
Signed-off-by: Zhigao Tong <[email protected]>
@solotzg
update 3
a7c3095 
Signed-off-by: Zhigao Tong <[email protected]>
solotzg and others added 2 commits December 16, 2021 12:47
@solotzg @riteme
Update docs/design/0000-00-00-architecture-of-distributed-storage-and…
cb9b183 
…-transaction.md

Co-authored-by: Xue Zhenliang <[email protected]>
@solotzg
update 4
52d2424 
Signed-off-by: Zhigao Tong <[email protected]>
riteme
riteme reviewed Dec 16, 2021
View reviewed changes
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
solotzg and others added 10 commits December 16, 2021 13:07
ilovesoup
ilovesoup suggested changes Dec 16, 2021
View reviewed changes
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
birdstorm
birdstorm reviewed Dec 17, 2021
View reviewed changes
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
docs/design/0000-00-00-architecture-of-distributed-storage-and-transaction.md Outdated Show resolved Hide resolved
solotzg and others added 5 commits December 17, 2021 17:36
@solotzg @CalvinNeo
Apply suggestions from code review
fb089c0 
Co-authored-by: Calvin Neo <[email protected]>
@solotzg
fix
d7d60a1 
Signed-off-by: Zhigao Tong <[email protected]>
@solotzg
update
c6d3531 
Signed-off-by: Zhigao Tong <[email protected]>
@solotzg
Merge branch 'master' into add-design-doc
c95da29
@solotzg
fix typo
4c3ff7e 
Signed-off-by: Zhigao Tong <[email protected]>
CalvinNeo
CalvinNeo approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2021
birdstorm
birdstorm approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CalvinNeo
CalvinNeo reviewed Dec 20, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@solotzg
Copy link
Contributor Author

solotzg commented Dec 20, 2021

/rebuild

@solotzg
Copy link
Contributor Author

solotzg commented Dec 20, 2021

/merge

@ti-chi-bot
Copy link
Member

@solotzg: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d4dbd23

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 20, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/509/cobertura/
(Coverage detail url is limited office network access)

lines: 42.5% (47529 out of 111812)
branches: 6.0% (73017 out of 1208735)

@ti-chi-bot ti-chi-bot merged commit 1b0834f into pingcap:master Dec 20, 2021
@solotzg solotzg deleted the add-design-doc branch December 21, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riteme riteme riteme left review comments

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@birdstorm birdstorm birdstorm approved these changes

@fuzhe1989 fuzhe1989 Awaiting requested review from fuzhe1989

@ilovesoup ilovesoup Awaiting requested review from ilovesoup

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@solotzg @ti-chi-bot @fuzhe1989 @sre-bot @ilovesoup @CalvinNeo @riteme @birdstorm