-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve auto generated fullstack tests #3592
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/251/cobertura/ lines: 40.2% (44316 out of 110111) |
… improve-fullstack-test
We can update it to |
Can you explain more about what's the difference between the old script and your new script? |
Add |
python2 is default installed by many OS, so I think using python2 is still better. |
One of the most important motivation of the old script is to add some tests after tiflash support the The main improvements the new script covered can be summarized as follows:
|
Added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 6c1bcbd
|
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/273/cobertura/ lines: 40.2% (44311 out of 110112) |
@lidezhu: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/276/cobertura/ lines: 40.3% (44434 out of 110200) |
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
remove some obsolete tests and add some fullstack test
Release note