Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little refinements on DAG code #3482

Merged
merged 3 commits into from
Nov 21, 2021
Merged

Conversation

fuzhe1989
Copy link
Contributor

@fuzhe1989 fuzhe1989 commented Nov 19, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

No logical changes.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 19, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 19, 2021
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 19, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/118/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43335 out of 122148)
branches: 5.4% (65917 out of 1219975)

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 19, 2021
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@fuzhe1989 fuzhe1989 requested a review from SeaRise November 19, 2021 10:13
@sre-bot
Copy link
Collaborator

sre-bot commented Nov 19, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/119/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43328 out of 122148)
branches: 5.4% (65884 out of 1219975)

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 21, 2021
@SeaRise
Copy link
Contributor

SeaRise commented Nov 21, 2021

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e158f65

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 21, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Nov 21, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/127/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43332 out of 122148)
branches: 5.4% (65903 out of 1219969)

@ti-chi-bot ti-chi-bot merged commit 9fca53d into pingcap:master Nov 21, 2021
@LittleFall LittleFall deleted the fuzhe/refine_dag branch November 22, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants