Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the efficiency of decode process of rows to columns #3431

Merged
merged 61 commits into from
Dec 7, 2021
Merged

Improve the efficiency of decode process of rows to columns #3431

merged 61 commits into from
Dec 7, 2021

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Nov 11, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #3241

Problem Summary:

What is changed and how it works?

Proposal: https://docs.google.com/document/d/1AGFQvYpKQfHsIFi8y1_BcB4aDmDSRo4tH5evT0lPiF0/edit?usp=sharing

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note 

Improve the efficiency for the process of decoding rows to columns

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 11, 2021
@lidezhu lidezhu changed the title [wip] Optimize more row to column [WIP] Optimize more row to column Nov 11, 2021
@lidezhu lidezhu changed the title [WIP] Optimize more row to column [WIP] Improve the efficiency of decode process of rows-to-coumns Nov 11, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2021
@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 1, 2021

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 1, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/229/cobertura/
(Coverage detail url is limited office network access)

lines: 40.8% (44986 out of 110287)
branches: 5.7% (68061 out of 1199688)

flowbehappy
flowbehappy approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@flowbehappy flowbehappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 6, 2021
JaySon-Huang
JaySon-Huang reviewed Dec 6, 2021
View reviewed changes
dbms/src/Storages/Transaction/tests/row_codec_test_basic_include.h Outdated
@@ -0,0 +1,336 @@
#pragma once
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest renaming this file to RowCodecUtils.h

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Renamed it to RowCodeTestUtils.h.

@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 7, 2021

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 7, 2021

/merge

@ti-chi-bot
Copy link
Member

@lidezhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c06444d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 7, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/286/cobertura/
(Coverage detail url is limited office network access)

lines: 40.8% (45022 out of 110479)
branches: 5.7% (68048 out of 1200116)

@ti-chi-bot ti-chi-bot merged commit 8363d85 into pingcap:master Dec 7, 2021
@lidezhu lidezhu deleted the decode-row-bench branch December 7, 2021 14:25
@lidezhu lidezhu restored the decode-row-bench branch December 28, 2021 08:02
@lidezhu lidezhu deleted the decode-row-bench branch April 11, 2022 07:28
@JaySon-Huang JaySon-Huang mentioned this pull request Apr 13, 2022
Closed
@JaySon-Huang JaySon-Huang mentioned this pull request Jun 16, 2022
Closed
@flowbehappy flowbehappy mentioned this pull request Jun 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinheLin JinheLin JinheLin left review comments

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@flowbehappy flowbehappy flowbehappy approved these changes

@solotzg solotzg Awaiting requested review from solotzg

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimization of write path from frame graph.
6 participants
@lidezhu @ti-chi-bot @sre-bot @flowbehappy @JaySon-Huang @JinheLin