Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: correct ci image project #3016

Merged
merged 2 commits into from
Sep 6, 2021
Merged

ci: correct ci image project #3016

merged 2 commits into from
Sep 6, 2021

Conversation

purelind
Copy link
Collaborator

@purelind purelind commented Sep 6, 2021 •
edited by solotzg
Loading

What problem does this PR solve?

close #3541

Correct ci image

What is changed and how it works?

Related changes

  • Need to cherry-pick to the release branch:

Check List

Tests

  • No code

Side effects

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • zhouqiang-cl

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2021
@purelind
Copy link
Collaborator Author

purelind commented Sep 6, 2021

/rebuild

2 similar comments
@purelind
Copy link
Collaborator Author

purelind commented Sep 6, 2021

/rebuild

@purelind
Copy link
Collaborator Author

purelind commented Sep 6, 2021

/rebuild

@purelind
Copy link
Collaborator Author

purelind commented Sep 6, 2021

/run-all-tests

@purelind
Copy link
Collaborator Author

purelind commented Sep 6, 2021

cc @zhouqiang-cl

zhouqiang-cl
zhouqiang-cl approved these changes Sep 6, 2021
View reviewed changes
Copy link

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2021
@purelind
Copy link
Collaborator Author

purelind commented Sep 6, 2021

cc @solotzg

solotzg
solotzg approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@purelind
Copy link
Collaborator Author

purelind commented Sep 6, 2021

/merge

@ti-chi-bot
Copy link
Member

@purelind: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@purelind: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@zhouqiang-cl
Copy link

/merge

@ti-chi-bot
Copy link
Member

@zhouqiang-cl: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6c17848

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@ti-chi-bot ti-chi-bot merged commit dc2bc1e into pingcap:master Sep 6, 2021
@zhouqiang-cl zhouqiang-cl added needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 labels Sep 7, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 7, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3039.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 7, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3040.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3041.

This was referenced Sep 7, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3042.

@solotzg solotzg deleted the purelind/correct-ci-image branch September 7, 2021 08:16
ti-chi-bot added a commit that referenced this pull request Oct 18, 2021
@ti-chi-bot
ci: correct ci image project (#3016) (#3042)
88a80ad
ti-chi-bot added a commit that referenced this pull request Nov 24, 2021
@ti-chi-bot
ci: correct ci image project (#3016) (#3039)
0dfd01a
ti-chi-bot added a commit that referenced this pull request Dec 9, 2021
@ti-chi-bot
ci: correct ci image project (#3016) (#3040)
2e07845
ti-chi-bot added a commit that referenced this pull request Dec 9, 2021
@ti-chi-bot
ci: correct ci image project (#3016) (#3041)
6842c20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

@solotzg solotzg solotzg approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 PR which needs to be cherry-picked to release-4.0 needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust ci image project name
4 participants
@purelind @ti-chi-bot @zhouqiang-cl @solotzg