Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in function mergeToViaEmplace #2617

Merged
merged 4 commits into from
Aug 9, 2021
Merged

Fix race in function mergeToViaEmplace #2617

merged 4 commits into from
Aug 9, 2021

Conversation

LittleFall
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #2607

Problem Summary: as the issue says.

What is changed and how it works?

Proposal: xxx

What's Changed: make variables atomic.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

  • No release note

@LittleFall LittleFall mentioned this pull request Aug 6, 2021
Closed
@LittleFall
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Collaborator

@fuzhe1989, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack).

@LittleFall
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 9, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 9776ea6 into pingcap:master Aug 9, 2021
@LittleFall LittleFall deleted the bugfix/race branch August 9, 2021 09:26
@LittleFall LittleFall added the needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 label Aug 9, 2021
@LittleFall
Copy link
Contributor Author

/run-cherry-picker

@ti-srebot ti-srebot mentioned this pull request Aug 9, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.2 in PR #2639

ti-chi-bot pushed a commit that referenced this pull request Aug 12, 2021
@ti-srebot
Fix race in function mergeToViaEmplace (#2617) (#2639)
a23adc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.2 PR which needs to be cherry-picked to release-5.2 status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiFlash crash in AggregateFunctionSumAddImpl::add
3 participants
@LittleFall @ti-srebot @fuzhe1989