Use ThreadFactory to auto set thread attributes #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-all-tests |
fuzhe1989
changed the title
|
/run-all-tests |
leiysky
reviewed
Jul 27, 2021
dbms/src/Common/ThreadCreator.h
Outdated
| /// 2. ThreadName | ||
| /// | ||
| /// ThreadCreator should only be constructed on stack. | ||
| class ThreadCreator |
There was a problem hiding this comment.
Maybe name with ThreadFactory?
fuzhe1989
changed the title
fuzhe1989
changed the title
|
/run-all-tests |
leiysky
reviewed
Jul 28, 2021
| template <typename F, typename ... Args> | ||
| ThreadPool::Job newJob(F && f, Args &&... args) | ||
| { | ||
| auto memory_tracker = current_memory_tracker; |
There was a problem hiding this comment.
Who will provide the current_memory_tracker in current thread?
There was a problem hiding this comment.
Currently only ProcessListElement's ctor.
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2499