Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix potential npe in executeTS (#2371) #2377

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jul 12, 2021

cherry-pick #2371 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2377

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tics.git pr/2377:release-4.0-245dd77cbf91

What problem does this PR solve?

Issue Number: close #2342

Problem Summary:
As the issue described.

What is changed and how it works?

Proposal: xxx

What's Changed:
The root cause is using an uninitialized pointer, this pr fix it by not using the pointer until it is initialized propertly.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

  • fix potential npe in executeTS during DAG compile

@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. labels Jul 12, 2021
@ti-srebot ti-srebot requested a review from JaySon-Huang July 12, 2021 04:38
@ti-srebot ti-srebot added this to the v4.0.14 milestone Jul 12, 2021
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@windtalker
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 12, 2021
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot ti-srebot merged commit 5d1ac48 into pingcap:release-4.0 Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants