Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiny cleanup #226

Closed
wants to merge 2 commits into from
Closed

tiny cleanup #226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe651fb
tiny cleanup
zhexuany Sep 9, 2019
5c1b5b9
Merge branch 'master' into tiny_cleanup
zhexuany Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dbms/src/Storages/Transaction/TiDB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ Field ColumnInfo::defaultValueToField() const
default:
throw Exception("Have not proccessed type: " + std::to_string(tp));
}
return Field();
Copy link
Contributor

@zanmato1984 zanmato1984 Sep 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some old compiler may require this return.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. closing this PR.

}

DB::Field ColumnInfo::getDecimalDefaultValue(const String & str) const
Expand Down