FLASH-200: Fix CI build fake pass #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
also revert 419a9d3
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
zyguan
approved these changes
Mar 28, 2019
|
I'll merge this PR anyway regardless of some tests being failed. Let's fix tests later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
CI build has been fake passing for quite a while, as the build script doesn't bail out after seeing a compiler error.
Fix the build script, also upgrade builder image by using gcc instead of clang, which is better compatible with some of latest code changes.