Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port DateLUT and LocalDate from ClickHouse #2143

Merged
merged 9 commits into from
Jun 12, 2021
Merged

Port DateLUT and LocalDate from ClickHouse #2143

merged 9 commits into from
Jun 12, 2021

Conversation

fuzhe1989
Copy link
Contributor

@fuzhe1989 fuzhe1989 commented Jun 11, 2021 •
edited
Loading

No description provided.

@fuzhe1989 fuzhe1989 changed the title Port DateLUT and LocalDate from ClickHouse [DNM] Port DateLUT and LocalDate from ClickHouse Jun 11, 2021
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@fuzhe1989 fuzhe1989 mentioned this pull request Jun 11, 2021
Merged
@fuzhe1989 fuzhe1989 changed the title [DNM] Port DateLUT and LocalDate from ClickHouse Port DateLUT and LocalDate from ClickHouse Jun 12, 2021
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

SchrodingerZhu
SchrodingerZhu approved these changes Jun 12, 2021
View reviewed changes
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Collaborator

@SchrodingerZhu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack).

@SchrodingerZhu
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 12, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@fuzhe1989 merge failed.

@SchrodingerZhu
Copy link
Contributor

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@fuzhe1989 merge failed.

@SchrodingerZhu
Copy link
Contributor

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit e80b18b into pingcap:master Jun 12, 2021
@fuzhe1989 fuzhe1989 deleted the fuzhe/port_ch/date branch June 12, 2021 23:54
JaySon-Huang
JaySon-Huang reviewed Jun 13, 2021
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. Ignore this comment.

@LittleFall LittleFall mentioned this pull request Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang left review comments

@SchrodingerZhu SchrodingerZhu SchrodingerZhu approved these changes

@leiysky leiysky Awaiting requested review from leiysky

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuzhe1989 @ti-srebot @SchrodingerZhu @JaySon-Huang