Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

str_to_date function push down #1961

Merged
merged 8 commits into from
Jun 3, 2021
Merged

str_to_date function push down #1961

merged 8 commits into from
Jun 3, 2021

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented May 23, 2021 •
edited
Loading

Signed-off-by: JaySon-Huang [email protected]

What problem does this PR solve?

Issue Number: #1942

We need to support pushing down the str_to_date function to TiFlash

What is changed and how it works?

Known issue

pingcap/tidb#24928

  1. TiDB has some incompatible parsing results compare with MySQL, the compatible issues are fixed in this PR, but not fixed by TiDB yet (maybe we should also fix them on the TiDB side to make TiDB and TiFlash be consistent)
    • '%b'/'%M' should be case insensitive
    • Parsing an empty string
    • Parsing the day that does not exist in the real world
    • Parsing the "Feb 29th" for leap year and non-leap year
    • Parsing some input for "%r" and "%T"

Related changes

  • Need to cherry-pick to the release branch: 5.0

Check List

Tests

  • Unit test

Side effects

Release note

  • Support pushing down the str_to_date function to TiFlash

@JaySon-Huang JaySon-Huang added the needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 label May 23, 2021
@JaySon-Huang JaySon-Huang self-assigned this May 23, 2021
@JaySon-Huang JaySon-Huang mentioned this pull request May 23, 2021
Merged
@JaySon-Huang
squash all commit of str_to_date
afd8901 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Confirm test pass
0f70f26 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang JaySon-Huang force-pushed the str_to_date_pushdown branch from f303d47 to 0f70f26 Compare May 24, 2021 06:27
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

2 similar comments
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@JaySon-Huang
Fix bug for str_to_date nullable input column
ab8b637 
Remove unreasonable include

Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Support calling strToDateDate on two column
229f388 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang
Port test cases from mysql; Fix bug for parsing "03-01-02 8:11:2.1234…
4893a34 
…56" with format "%Y-%m-%d %H:%i:%S.%#"

Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang JaySon-Huang force-pushed the str_to_date_pushdown branch from 525ce5b to 4893a34 Compare May 25, 2021 11:17
@JaySon-Huang JaySon-Huang requested a review from zanmato1984 May 25, 2021 11:20
@JaySon-Huang JaySon-Huang mentioned this pull request May 25, 2021
Closed
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

zanmato1984
zanmato1984 approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 30db147 into pingcap:master Jun 3, 2021
@JaySon-Huang JaySon-Huang deleted the str_to_date_pushdown branch June 3, 2021 07:02
@ti-srebot ti-srebot mentioned this pull request Jun 3, 2021
Merged
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #2063

@JaySon-Huang JaySon-Huang added the type/new-feature Issue or PR for new feature label Jun 3, 2021
@LittleFall LittleFall mentioned this pull request Jun 4, 2021
Merged
JaySon-Huang added a commit that referenced this pull request Jun 17, 2021
@ti-srebot @LittleFall @JaySon-Huang
str_to_date function push down (#1961) (#2063)
67f3c7e 
Co-authored-by: Zhi Qi <[email protected]>
Co-authored-by: JaySon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees

@JaySon-Huang JaySon-Huang

Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/new-feature Issue or PR for new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaySon-Huang @ti-srebot @zanmato1984