Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASH-194] Fix Bug About ApplySnapshot #19

Closed
wants to merge 6 commits into from
Closed

[FLASH-194] Fix Bug About ApplySnapshot #19

wants to merge 6 commits into from

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Mar 23, 2019

Based on #16

  • We need to make sure that operation onSnapshot and onServiceCommand should not be executed concurrently.
  • In KVStore::onSnapshot, we should replace the data in old region with the new region's rather than replace the whole region in KVStore.

@solotzg solotzg mentioned this pull request Mar 23, 2019
Merged
@zanmato1984
Copy link
Contributor

/run-integration-tests

@solotzg
Copy link
Contributor Author

solotzg commented Mar 25, 2019

only need #20 now, close it.

@solotzg solotzg closed this Mar 25, 2019
@solotzg solotzg deleted the FLASH-194 branch March 30, 2019 04:30
@hehechen hehechen mentioned this pull request Jul 6, 2022
Closed
@bestwoody bestwoody mentioned this pull request Sep 13, 2022
Closed
@hehechen hehechen mentioned this pull request Sep 26, 2022
Closed
@yibin87 yibin87 mentioned this pull request Oct 12, 2023
Open
@yibin87 yibin87 mentioned this pull request Nov 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solotzg @zanmato1984