Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast negative number string as unsigned int (#1762) #1768

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Apr 13, 2021

cherry-pick #1762 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/1768

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tics.git pr/1768:release-5.0-5f0663bc7b5c

Signed-off-by: Yu Lei [email protected]

What problem does this PR solve?

Issue Number: close #1761

Problem Summary:

What is changed and how it works?

What's Changed:
The root cause is TiDB will cast string to signed integer even if result type is unsigned.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Integration test

Release note

  • Fix the problem that TiFlash coprocessor's cast string as int function may produce incorrect result.

@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. labels Apr 13, 2021
@ti-srebot ti-srebot added this to the v5.0.1 milestone Apr 13, 2021
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leiysky
Copy link
Contributor

leiysky commented Apr 15, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@ti-srebot
Copy link
Collaborator Author

Your auto merge job has been accepted, waiting for:

  • 1774

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot ti-srebot merged commit d42e2a0 into pingcap:release-5.0 Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants