Tidy up test cases for clustered index #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaySon-Huang
force-pushed
the
fix_clustered_index_tests
branch
from
3b9f158 to
b157530
Compare
|
Hi, I think the ci error for clustered index has been fixed by #1591 |
Signed-off-by: JaySon-Huang <[email protected]>
JaySon-Huang
force-pushed
the
fix_clustered_index_tests
branch
from
b157530 to
b1bf8c0
Compare
|
@windtalker Yes, I found that PR after filing this PR because I met an error when merging PRs on release-5.0. |
JaySon-Huang
changed the title
windtalker
reviewed
Mar 20, 2021
| source ../../_vars.sh | ||
| setup_dylib_path | ||
| #source ../../_vars.sh | ||
| #setup_dylib_path |
There was a problem hiding this comment.
This is a script located in tiflash repo rather than tics repo. This will make an error if we only checkout the tics repo and run the tests.
And I find that I can run the tests without these two lines.
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
JaySon-Huang
added
the
needs-cherry-pick-release-5.0
|
/run-all-tests |
|
cherry pick to release-5.0 in PR #1603 |
ti-srebot
added a commit
that referenced
this pull request
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Tidy up test cases after #1591
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note