Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DM] CI run gtest cases && fix tests #156

Closed

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Aug 6, 2019

Changes:

  • Comment in PR with /run-integration-tests will also run gtest. code
    • introduce unittests binary:
      • unit_tests_dbms recursively glob all tests defined in gtest_*.cpp under dbms/ define at here. Binary size is about 240 MB.
      • unit_tests_libcommon. Binary size is about 4 MB defined at here
    • Build unittests written with gtest and copy to docker image (only in Debug mode). code
    • */CMakeLists.txt mark all tests binary as EXCLUDE_FROM_ALL, so that we can ignore those binaries when running make all

Bug fix:

  • Fix compile errors in DM tests
  • Include missing headers in DM tests
  • Add DeltaMerge Chunk's default constructor

TODO:
Tests define with independent main entrance can change to use gtest framework and be integrated to CI flow

@JaySon-Huang
Copy link
Contributor Author

/build

2 similar comments
@JaySon-Huang
Copy link
Contributor Author

/build

@JaySon-Huang
Copy link
Contributor Author

/build

@JaySon-Huang
Copy link
Contributor Author

/rebuild

@JaySon-Huang
Copy link
Contributor Author

/run-integration-tests

2 similar comments
@JaySon-Huang
Copy link
Contributor Author

/run-integration-tests

@JaySon-Huang
Copy link
Contributor Author

/run-integration-tests

@JaySon-Huang JaySon-Huang changed the title CI run gtest cases [DM] CI run gtest cases && fix tests Aug 7, 2019
@JaySon-Huang JaySon-Huang deleted the ci-run-gtest-cases branch September 16, 2019 03:13
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this pull request Jul 29, 2024
JaySon-Huang pushed a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant