Throw DB Exception when AggregateFunctionNullUnary handles unexpected column #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
added
the
first-time-contributor
windtalker
reviewed
Mar 1, 2021
| const ColumnNullable * column = static_cast<const ColumnNullable *>(columns[0]); | ||
| if (!column->isNullAt(row_num)) | ||
| const IColumn * column = columns[0]; | ||
| const auto * maybe_nullable_column = dynamic_cast<const ColumnNullable *>(column); |
There was a problem hiding this comment.
Since the input is a nullable type, and it can not be converted to ColumnNullable, I guess that it is a ColumnConst, so I think its better to
organize the code as follows:
if (const auto * column_nullable= dynamic_cast<const ColumnNullable *>(column))
{}
else if (const auto * column_const = dynamic_cast<const ColumnConst *>(column))
{}
eles
{
// throw error
}
There was a problem hiding this comment.
After throw custom exception it is revealed that the actual column type of issue SQL is Int64 a.k.a ColumnVector<Int64>, not ColumnConst.
There was a problem hiding this comment.
Yes, as we discussed offline, this is because the type passed by TiDB is not correct, we should fix the TiDB bug and to see what happens here.
|
Should add some tests to verify the fix. |
|
/run-all-tests |
tisonkun
changed the title
|
/run-all-tests |
windtalker
reviewed
Mar 5, 2021
…column Signed-off-by: tison <[email protected]>
tisonkun
changed the title
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #1492
Follow up for #481
Problem Summary:
What is changed and how it works?
Properly handle nonnull column case when
empty_input_as_nullistrueto get the correct semantic and avoid nullptr.Related changes
Check List
It is an obvious fix but we can add the original SQL as an integrated test.
Release note
N/A