Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exchange receiver support multi thread read #1211

Merged
merged 2 commits into from
Nov 6, 2020
Merged

exchange receiver support multi thread read #1211

merged 2 commits into from
Nov 6, 2020

Conversation

windtalker
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #1210

Problem Summary:

As the issue described.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Decouple ExchangeReceiverInputStream and the code of reading from grpc. Since we already support reading from grpc concurrently, it is easy to support multi thread read from ExchangeReceiverInputStream after decoupling ExchangeReceiverInputStream and reading from grpc.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • exchange receiver support multi thread read

@windtalker windtalker added the type/enhancement The issue or PR belongs to an enhancement. label Nov 6, 2020
@windtalker
Copy link
Contributor Author

/run-all-tests

@fzhedu fzhedu self-requested a review November 6, 2020 06:40
fzhedu
fzhedu approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@fzhedu fzhedu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Collaborator

@fzhedu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack).

hanfei1991
hanfei1991 approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 6, 2020
@windtalker windtalker added the status/can-merge Indicates a PR has been approved by a committer. label Nov 6, 2020
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit f32bb23 into pingcap:master Nov 6, 2020
@windtalker windtalker deleted the exchange_client_multi_thread branch November 9, 2020 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

@fzhedu fzhedu fzhedu approved these changes

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multi-thread read for ExchangeReceiver
4 participants
@windtalker @ti-srebot @fzhedu @hanfei1991