Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory metric of data-sharing is incorrect #8856

Closed
JinheLin opened this issue Mar 21, 2024 · 0 comments · Fixed by #8857
Closed

Memory metric of data-sharing is incorrect #8856

JinheLin opened this issue Mar 21, 2024 · 0 comments · Fixed by #8857
Assignees
@JinheLin
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.0 component/storage severity/moderate type/bug The issue is confirmed as a bug.

Comments

@JinheLin
Copy link
Contributor

The default value of dt_max_sharing_column_bytes_for_all is 2GB https://github.com/pingcap/tiflash/blob/master/dbms/src/Interpreters/Settings.h#L222

But the metric in Grafana is beyond 10GB, the left part of the picture below:

image
@JinheLin JinheLin added type/bug The issue is confirmed as a bug. component/storage affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.0 labels Mar 21, 2024
@JinheLin JinheLin self-assigned this Mar 21, 2024
@JinheLin JinheLin mentioned this issue Mar 21, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Mar 25, 2024
@JinheLin
Storages: Refine memory tracker of data sharing (#8857)
12d7a96 
close #8856
@ti-chi-bot ti-chi-bot mentioned this issue Mar 26, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Mar 28, 2024
@ti-chi-bot
Storages: Refine memory tracker of data sharing (#8857) (#8871)
21c689f 
close #8856
This was referenced Apr 11, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Apr 11, 2024
@ti-chi-bot
Storages: Refine memory tracker of data sharing (#8857) (#8934)
d83fbe3 
close #8856
ti-chi-bot bot pushed a commit that referenced this issue Apr 12, 2024
@ti-chi-bot
Storages: Refine memory tracker of data sharing (#8857) (#8935)
dcc3249 
close #8856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JinheLin JinheLin

Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.0 component/storage severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Storages: Refine memory tracker of data sharing JinheLin/tiflash-1
1 participant
@JinheLin