Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MemTableSet may contain ColumnFileTiny objects but missed out when extracting remote page ids. #8436

Closed
JinheLin opened this issue Nov 29, 2023 · 0 comments · Fixed by #8437
Closed

MemTableSet may contain ColumnFileTiny objects but missed out when extracting remote page ids. #8436

JinheLin opened this issue Nov 29, 2023 · 0 comments · Fixed by #8437
Assignees
@JinheLin
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@JinheLin
Copy link
Contributor

According to code in https://github.com/pingcap/tiflash/blob/master/dbms/src/Storages/DeltaMerge/DeltaMergeStore.cpp#L604-L639, if the rows or size of the writting block is greater or equal to delta_cache_limit_rows / 4 or delta_cache_limit_bytes / 4, this block will be directly persisted into a ColumnFileTiny object and appened to MemTableSet.

But logic in SegmentReadTask (in master) and RNReadTask (in release-7.5) only extracting remote page ids from ColumnFilePersistedSet.
@JinheLin JinheLin added the type/bug The issue is confirmed as a bug. label Nov 29, 2023
@JinheLin JinheLin self-assigned this Nov 29, 2023
@JinheLin JinheLin added affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major labels Nov 29, 2023
@JinheLin JinheLin mentioned this issue Nov 29, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Nov 29, 2023
@JinheLin
Disagg: Fix the problem of missing remote page id in MemTableSet. (#8437
73e427f 
)

close #8436
@ti-chi-bot ti-chi-bot mentioned this issue Nov 29, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 15, 2023
@ti-chi-bot
Disagg: Fix the problem of missing remote page id in MemTableSet. (#8437
eb9c922 
) (#8440)

close #8436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JinheLin JinheLin

Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disagg: Fix the problem of missing remote page id in MemTableSet. JinheLin/tiflash-1
1 participant
@JinheLin