Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopwatch::elapsedFromLastTime may return negative value #8336

Closed
guo-shaoge opened this issue Nov 8, 2023 · 1 comment · Fixed by #8338
Closed

Stopwatch::elapsedFromLastTime may return negative value #8336

guo-shaoge opened this issue Nov 8, 2023 · 1 comment · Fixed by #8338
Assignees
@guo-shaoge
Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 affects-7.3 affects-7.4 affects-7.5 This bug affects the 7.5.x(LTS) versions. component/compute severity/major type/bug The issue is confirmed as a bug.

Comments

@guo-shaoge
Copy link
Contributor

guo-shaoge commented Nov 8, 2023 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

test pr: https://github.com/pingcap/tiflash/pull/8335/files

You can see the the argument of inc_value of function ResourceControlQueue::updateStatistics(inc_value) is -1(uint64_max), which is unexpected. Because inc_value means the cpu time of a pipeline tasks used.
Oy9qTM5geI

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)
@guo-shaoge guo-shaoge added the type/bug The issue is confirmed as a bug. label Nov 8, 2023
@guo-shaoge guo-shaoge self-assigned this Nov 8, 2023
@guo-shaoge guo-shaoge added affects-7.3 affects-7.4 affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Nov 8, 2023
@JaySon-Huang JaySon-Huang mentioned this issue Nov 8, 2023
Merged
12 tasks
@JaySon-Huang
Copy link
Contributor

The function is added by #4537 since v6.1

@JaySon-Huang JaySon-Huang reopened this Nov 9, 2023
@ti-chi-bot ti-chi-bot bot closed this as completed in #8338 Nov 9, 2023
ti-chi-bot bot pushed a commit that referenced this issue Nov 9, 2023
@JaySon-Huang
*: Fix time step backward for Stopwatch::elapsedFromLastTime (#8338)
c81fd41 
close #8336
This was referenced Nov 9, 2023
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 9, 2023
@ti-chi-bot
*: Fix time step backward for Stopwatch::elapsedFromLastTime (#8338) (
f6516cc 
#8347)

close #8336
ti-chi-bot bot pushed a commit that referenced this issue Nov 10, 2023
@ti-chi-bot
*: Fix time step backward for Stopwatch::elapsedFromLastTime (#8338) (
2d8afbe 
#8346)

close #8336
ti-chi-bot bot pushed a commit that referenced this issue Nov 10, 2023
@ti-chi-bot
*: Fix time step backward for Stopwatch::elapsedFromLastTime (#8338) (
8138e8a 
#8343)

close #8336
ti-chi-bot bot pushed a commit that referenced this issue Dec 7, 2023
@ti-chi-bot
*: Fix time step backward for Stopwatch::elapsedFromLastTime (#8338) (
f2691ea 
#8342)

close #8336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guo-shaoge guo-shaoge

Labels
affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-6.3 affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.2 affects-7.3 affects-7.4 affects-7.5 This bug affects the 7.5.x(LTS) versions. component/compute severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: Fix time step backward for Stopwatch::elapsedFromLastTime JaySon-Huang/tiflash
3 participants
@jebter @JaySon-Huang @guo-shaoge