Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The id of S3GCManager is not set correctly #7681

Closed
JaySon-Huang opened this issue Jun 20, 2023 · 0 comments · Fixed by #7682
Closed

The id of S3GCManager is not set correctly #7681

JaySon-Huang opened this issue Jun 20, 2023 · 0 comments · Fixed by #7682
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.

Comments

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jun 20, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

When deployed with tidb-operator, we use a config file as following

[flash]
service_addr = "0.0.0.0:3930"
tidb_status_addr = "cluster-tidb.tidb.svc:10080"
  [flash.proxy]
  addr = "0.0.0.0:20170"
  advertise-addr = "cluster-tiflash-0.cluster-tiflash-peer.tidb.svc:20170"
  engine-addr = "cluster-tiflash-0.cluster-tiflash-peer.tidb.svc:3930"

2. What did you expect to see? (Required)

Under disagg arch, S3GCManager should use flash.proxy.engine-addr as its own ID. Other S3GC non-leader node use this ID to connect to the S3GC leader

3. What did you see instead (Required)

Now S3GCManager use flash.service_addr as its own ID

4. What is your TiFlash version? (Required)

master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant