Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CrossJoin implementation performance improvement #6706

Closed
yibin87 opened this issue Feb 1, 2023 · 0 comments · Fixed by #6707
Closed

CrossJoin implementation performance improvement #6706

yibin87 opened this issue Feb 1, 2023 · 0 comments · Fixed by #6707
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@yibin87
Copy link
Contributor

yibin87 commented Feb 1, 2023

Enhancement

Current tiflash cross join implementation is not good enough:

  1. Column size is not welled-reserved while its final size can be calculated accurately
  2. Column elements are inserted using insertFrom instead of insertRangeFrom, which is not efficient
@yibin87 yibin87 added the type/enhancement The issue or PR belongs to an enhancement. label Feb 1, 2023
@yibin87 yibin87 mentioned this issue Feb 1, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Feb 2, 2023
@yibin87
Optimize cross join impl (#6707)
1bad64f 
close #6706
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this issue Feb 13, 2023
@yibin87 @ywqzzy
Optimize cross join impl (pingcap#6707)
7306a8a 
close pingcap#6706

Signed-off-by: ywqzzy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize cross join impl yibin87/tiflash
1 participant
@yibin87