Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageStorage: unstable rename test in ut and mock tests #5761

Closed
JaySon-Huang opened this issue Sep 1, 2022 · 0 comments · Fixed by #5762
Closed

PageStorage: unstable rename test in ut and mock tests #5761

JaySon-Huang opened this issue Sep 1, 2022 · 0 comments · Fixed by #5762
Assignees
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Sep 1, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Introduce by #5739

After #5739, we should not call shutdown for a table but later restore the DeltaMergeStore instance without restoring the global PageStorage instance. Cause store->shutdown will remove the callbacks, also clean the external ids ptrs from PageStorage. After restoring the DeltaMergeStore from disk without restoring the global PageStorage instance, it will run into removing all dtfiles from disk.

2. What did you expect to see? (Required)

3. What did you see instead (Required)

https://ci.pingcap.net/blue/organizations/jenkins/tiflash-ghpr-integration-tests/detail/tiflash-ghpr-integration-tests/8532/pipeline/194

4. What is your TiFlash version? (Required)

927b52f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant