Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent flush lead to CPU waste #5409

Closed
breezewish opened this issue Jul 19, 2022 · 0 comments · Fixed by #5410
Closed

Concurrent flush lead to CPU waste #5409

breezewish opened this issue Jul 19, 2022 · 0 comments · Fixed by #5410
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. component/storage severity/minor type/bug The issue is confirmed as a bug.

Comments

@breezewish
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Perform two flush over the same segment concurrently. One could be triggered in background and another could be triggered via write.

2. What did you expect to see? (Required)

One flush wait for another.

3. What did you see instead (Required)

CPU is 100% during one flush waiting for another.

4. What is your TiFlash version? (Required)

master
@breezewish breezewish added the type/bug The issue is confirmed as a bug. label Jul 19, 2022
@breezewish breezewish mentioned this issue Jul 19, 2022
Merged
12 tasks
@breezewish breezewish added affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.2 affects-5.4 This bug affects the 5.4.x(LTS) versions. severity/minor labels Jul 19, 2022
ti-chi-bot pushed a commit that referenced this issue Jul 20, 2022
@breezewish
Yield CPU for concurrent flush and concurrent mergeDelta (#5410)
9ccfc4b 
close #5409
This was referenced Jul 20, 2022
Closed
Merged
@breezewish breezewish mentioned this issue Jul 23, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jul 27, 2022
@breezewish
test: Add tests case when deltaMergeBySplit + { flushCache | split } …
ad5201c 
…occurs simultaneously (#5454)

ref #5409
This was referenced Jul 27, 2022
Closed
Merged
ti-chi-bot added a commit that referenced this issue Aug 18, 2022
@ti-chi-bot
Yield CPU for concurrent flush and concurrent mergeDelta (#5410) (#5424)
4f6cf29 
close #5409
ti-chi-bot added a commit that referenced this issue Aug 22, 2022
@ti-chi-bot
test: Add tests case when deltaMergeBySplit + { flushCache | split } …
45202b0 
…occurs simultaneously (#5454) (#5486)

ref #5409
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. component/storage severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Yield CPU for concurrent flush and concurrent mergeDelta pingcap/tiflash
3 participants
@breezewish @flowbehappy @JaySon-Huang