Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support CastTimeAsDuration in TiFlash #5306

Closed
windtalker opened this issue Jul 7, 2022 · 6 comments · Fixed by #5548
Closed

support CastTimeAsDuration in TiFlash #5306

windtalker opened this issue Jul 7, 2022 · 6 comments · Fixed by #5548
Assignees
Labels
component/compute type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@windtalker
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

Describe the feature you'd like:

Support CastTimeAsDuration in TiFlash
TiDB's implementation:
https://github.com/pingcap/tidb/blob/562bb9f9e2c194c3f398300d5e5e920965da9f47/expression/builtin_cast.go#L1454
Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@windtalker windtalker added the type/feature-request Categorizes issue or PR as related to a new feature. label Jul 7, 2022
@AntiTopQuark
Copy link
Contributor

Hi, has this job been done by someone?

I want to do this job. But I don't have much experience and I'm a little busy. I may do it for a long time. Is there a Deadline in this job?

@Willendless
Copy link
Contributor

Hi, has this job been done by someone?

I want to do this job. But I don't have much experience and I'm a little busy. I may do it for a long time. Is there a Deadline in this job?

Hi, feel free to give it a try. There is no hard deadline for this task. I can assign this task to you :)

@Willendless
Copy link
Contributor

/assign @AntiTopQuark

@AntiTopQuark
Copy link
Contributor

/assign @AntiTopQuark

Thank you, I will try to do my best to do it well

@Willendless
Copy link
Contributor

Willendless commented Jul 18, 2022

/label good first issue

@ti-chi-bot
Copy link
Member

@Willendless: The label(s) good-first-issue cannot be applied. These labels are supported: duplicate, first-time-contributor, good first issue, help wanted, invalid, question, wontfix, make-local-great-again, needs-cherry-pick-release-3.1, needs-cherry-pick-release-4.0, needs-cherry-pick-release-5.0-rc, needs-cherry-pick-release-5.0, needs-cherry-pick-release-5.1, needs-cherry-pick-release-5.2, needs-cherry-pick-release-5.3, needs-cherry-pick-release-5.4, needs-cherry-pick-release-6.0, needs-cherry-pick-release-6.1, needs-rebase.

In response to this:

/label good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/compute type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants