Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big region snapshot adaption and applying snapshot improvement #5237

Closed
flowbehappy opened this issue Jun 27, 2022 · 1 comment · Fixed by #6378
Closed

Big region snapshot adaption and applying snapshot improvement #5237

flowbehappy opened this issue Jun 27, 2022 · 1 comment · Fixed by #6378
Assignees
Labels
component/storage type/enhancement The issue or PR belongs to an enhancement.

Comments

@flowbehappy
Copy link
Contributor

Enhancement

Applying a snapshot requires writing a delete range and a DTFile to the Delta layer of 1 or more segments. Because the snapshot is relatively large, it will

  • Very likely trigger a delta merge, which causes write amplification.
  • A big snapshot will directly cause write stall.

Note that, most of the time, the snapshot is not overlapped with the data in the relative segments. I think we can find a way to avoid writing snapshots to the Delta layer, as LSM-Tree does.

@flowbehappy flowbehappy added type/enhancement The issue or PR belongs to an enhancement. component/storage labels Jun 27, 2022
@breezewish
Copy link
Member

breezewish commented Jul 5, 2022

Related TiKV change: tikv/tikv#11515

We would implement the change in a series of incremental PRs:

TiFlash Proxy

Segment Multi Merge

Segment Split

Segment ReplaceData

Improve Snapshot Ingestion

ti-chi-bot pushed a commit that referenced this issue Sep 16, 2022
ti-chi-bot pushed a commit that referenced this issue Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/storage type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants