Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test failed when run function related test with Interpreter Tests. #5081

Closed
ywqzzy opened this issue Jun 7, 2022 · 1 comment · Fixed by #5021
Closed

Unit test failed when run function related test with Interpreter Tests. #5081

ywqzzy opened this issue Jun 7, 2022 · 1 comment · Fixed by #5021
Assignees
Labels
severity/minor type/bug The issue is confirmed as a bug.

Comments

@ywqzzy
Copy link
Contributor

ywqzzy commented Jun 7, 2022

Bug Report

Thanks to @SchrodingerZhu. He ran across this bug and helped me figure out how it happened.

1. Minimal reproduce step (Required)

./dbms/gtests_dbms --gtest_filter="*Date*:*Join*"

2. What did you expect to see? (Required)

All test passed.

3. What did you see instead (Required)

origin_img_v2_97b2d9b1-cc41-4d6b-af1b-f2d3e0c9fa1g

4. What is your TiFlash version? (Required)

Nightly

@ywqzzy ywqzzy added the type/bug The issue is confirmed as a bug. label Jun 7, 2022
@ywqzzy ywqzzy self-assigned this Jun 7, 2022
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Jun 7, 2022

When multiple Function tests run, the unit test will call DB::registerFunctions() multiple times, then in the InterpreterTest::SetUpTestCase(), it will raise an exception, lead to the DB::registerAggregationFunction() not called.
It's better to wrap it into anthor "try...catch block".
Current code:
iyO09FkJJY
Modified code:
middle_img_v2_ed862979-8ce8-4709-98d8-584cb53e00eg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant