Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function unit test should follow the same logic in DAGExpressionAnalyzer when building function #4830

Closed
windtalker opened this issue May 6, 2022 · 0 comments · Fixed by #4861
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@windtalker
Copy link
Contributor

windtalker commented May 6, 2022

Enhancement

We already have a function test framework for function unit test, however, it just use executeFunction to build and execute the function, while when we build a function in DAGExpressionAnalyzer, we may have rewrite so the orignal function will be rewrite to some other functions, for exmaple:
ifnull(col1, col2)
is rewriten to
multiif(isnull(col1), col2, assumeNotNull(col1))
in buildIfNullFunction

We need to enhance our function test framework to ensure that function unit test follow the same logic in DAGExpressionAnalyzer when building function, otherwise unit test may be useless, take #4829 for example.

@windtalker windtalker added the type/enhancement The issue or PR belongs to an enhancement. label May 6, 2022
@windtalker windtalker mentioned this issue May 6, 2022
12 tasks
@ti-chi-bot ti-chi-bot mentioned this issue May 6, 2022
12 tasks
@windtalker windtalker self-assigned this May 10, 2022
ti-chi-bot pushed a commit that referenced this issue May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant