upgrade from v5.2.4 to v6.0.0 fail, tiflash upgrade fail

[seiya-annie]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

install tidb cluster with v5.2.4, using default config
upgrade to v6.0.0

2. What did you expect to see? (Required)

upgrade success

3. What did you see instead (Required)

upgrade fail with:

2022.04.19 17:34:36.789966 [ 1 ] Application: The configuration "path" is deprecated. Check [storage] section for new style.
[2022/04/19 17:37:36.138 +08:00] [WARN] [StorageConfigParser.cpp:229] ["Application:The configuration "path" is deprecated. Check [storage] section for new style."] [thread_id=1]

4. What is your TiFlash version? (Required)

[2022/04/19 17:34:36.564 +08:00] [INFO] [] ["TiFlash build info: TiFlash\nRelease Version: v5.2.4\nEdition: Community\nGit Commit Hash: 493855d\nGit Branch: heads/refs/tags/v5.2.4\nUTC Build Time: 2022-04-18 03:16:43\nProfile: RELWITHDEBINFO\n"] [thread_id=1]

[fzhedu]

the waring can be ignored. Do you use tiup to upgrade the cluster? use tiup cluster display to see the node status.

[seiya-annie]

[seiya-annie]

tiup report upgrade fail and exit

[seiya-annie]

change wait-time to 300s, still fail

Upgrading component tiflash
Restarting instance 172.16.5.101:9000

Error: failed to restart: 172.16.5.101 tiflash-9000.service, please check the instance's log(/home/tidb/deploy/tiflash-9000/log) for more detail.: timed out waiting for tiflash 172.16.5.101:9000 to be ready after 300s: Get "http://172.16.5.101:20292/tiflash/store-status": dial tcp 172.16.5.101:20292: connect: connection refused

[seiya-annie]

tiflash_tikv.log

[seiya-annie]

find fatal in tiflash_tikv.log

[2022/04/19 18:27:21.108 +08:00] [FATAL] [[lib.rs:463](http://lib.rs:463/)] ["failed to load_latest_options \"Invalid argument: Unable to parse the specified CF option disable_write_stall\""] [backtrace="stack backtrace:\n   0: tikv_util::set_panic_hook::{{closure}}\n   1: std::panicking::rust_panic_with_hook\n             at library/std/src/[panicking.rs:595](http://panicking.rs:595/)\n   2: std::panicking::begin_panic_handler::{{closure}}\n             at library/std/src/[panicking.rs:497](http://panicking.rs:497/)\n   3: std::sys_common::backtrace::__rust_end_short_backtrace\n             at library/std/src/sys_common/[backtrace.rs:141](http://backtrace.rs:141/)\n   4: rust_begin_unwind\n             at library/std/src/[panicking.rs:493](http://panicking.rs:493/)\n   5: std::panicking::begin_panic_fmt\n             at library/std/src/[panicking.rs:435](http://panicking.rs:435/)\n   6: engine_rocks::raw_util::new_engine_opt::{{closure}}\n   7: engine_rocks::raw_util::new_engine_opt\n   8: server::server::run_tikv\n   9: server::proxy::run_proxy\n  10: _ZN2DB20RaftStoreProxyRunner20runRaftStoreProxyFFIEPv\n             at /home/jenkins/agent/workspace/build-common/go/src/[github.com/pingcap/tics/dbms/src/Server/Server.cpp:461\n](http://github.com/pingcap/tics/dbms/src/Server/Server.cpp:461/n)  11: start_thread\n  12: clone\n"] [location=components/engine_rocks/src/[raw_util.rs:122](http://raw_util.rs:122/)] [thread_name=<unnamed>]```

[fzhedu]

[2022/04/19 18:27:21.108 +08:00] [FATAL] [lib.rs:463] ["failed to load_latest_options \"Invalid argument: Unable to parse the specified CF option disable_write_stall\""] [backtrace="stack backtrace:\n   0: tikv_util::set_panic_hook::{{closure}}\n   1: std::panicking::rust_panic_with_hook\n             at library/std/src/panicking.rs:595\n   2: std::panicking::begin_panic_handler::{{closure}}\n             at library/std/src/panicking.rs:497\n   3: std::sys_common::backtrace::__rust_end_short_backtrace\n             at library/std/src/sys_common/backtrace.rs:141\n   4: rust_begin_unwind\n             at library/std/src/panicking.rs:493\n   5: std::panicking::begin_panic_fmt\n             at library/std/src/panicking.rs:435\n   6: engine_rocks::raw_util::new_engine_opt::{{closure}}\n   7: engine_rocks::raw_util::new_engine_opt\n   8: server::server::run_tikv\n   9: server::proxy::run_proxy\n  10: _ZN2DB20RaftStoreProxyRunner20runRaftStoreProxyFFIEPv\n             at /home/jenkins/agent/workspace/build-common/go/src/github.com/pingcap/tics/dbms/src/Server/Server.cpp:461\n  11: start_thread\n  12: clone\n"] [location=components/engine_rocks/src/raw_util.rs:122] [thread_name=<unnamed>]

according to this fatal message, please remove 'disable_write_stall' in the config.

[seiya-annie]

no config set in topo file

[zanmato1984]

PR merged. No other version affected. Can we close this one? @seiya-annie

[seiya-annie]

PR merged. No other version affected. Can we close this one? @seiya-annie

ok, I closed it