Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override IProfilingBlockInputStream.readSuffixImpl instead of IProfilingBlockInputStream.readSuffix #4458

Closed
SeaRise opened this issue Mar 28, 2022 · 0 comments · Fixed by #4457
Labels
severity/minor type/bug The issue is confirmed as a bug.

Comments

@SeaRise
Copy link
Contributor

SeaRise commented Mar 28, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

void IProfilingBlockInputStream::readSuffix()
{
    auto start_time = info.total_stopwatch.elapsed();
    forEachChild([&] (IBlockInputStream & child)
    {
        child.readSuffix();
        return false;
    });

    readSuffixImpl();
    info.updateExecutionTime(info.total_stopwatch.elapsed() - start_time);
}

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant