Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop when hardlink is enabled and exist incomplete writebatch #4426

Closed
JaySon-Huang opened this issue Mar 24, 2022 · 1 comment · Fixed by #4452
Closed

Infinite loop when hardlink is enabled and exist incomplete writebatch #4426

JaySon-Huang opened this issue Mar 24, 2022 · 1 comment · Fixed by #4452
Assignees
@jiaqizho
Labels
affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 severity/minor type/bug The issue is confirmed as a bug.

Comments

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Mar 24, 2022 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

enable hardlink by

profiles.default.dt_storage_pool_log_gc_force_hardlink_rate : 0.8
profiles.default.dt_storage_pool_data_gc_force_hardlink_rate : 0.8
profiles.default.dt_storage_pool_meta_gc_force_hardlink_rate : 0.8

restart tiflash and check the logging

2. What did you expect to see? (Required)

The hard link optimization can run normally

3. What did you see instead (Required)

Infinite loop

[2022/03/24 11:22:28.315 +00:00] [WARN] [<unknown>] ["PageFile:[expect_batch_bytes=4160631355] [meta_size=36382152] [file=/data0/db/data/t_71/log/page_1788_3/meta] ignored."] [thread_id=29]

image

4. What is your TiFlash version? (Required)
@JaySon-Huang JaySon-Huang added the type/bug The issue is confirmed as a bug. label Mar 24, 2022
@JaySon-Huang JaySon-Huang mentioned this issue Mar 25, 2022
Closed
12 tasks
@JaySon-Huang JaySon-Huang mentioned this issue Mar 28, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 28, 2022
@JaySon-Huang
Fix hardlink may cause dead loop, also disable config gc_hardlink_rate (
759e416 
#4452)

close #4426
This was referenced Mar 28, 2022
Closed
Closed
Merged
ti-chi-bot added a commit that referenced this issue Mar 28, 2022
@ti-chi-bot
Fix hardlink may cause dead loop, also disable config gc_hardlink_rate (
5aea73d 
#4452) (#4456)

close #4426
@flowbehappy
Copy link
Contributor

Hardlink is abandoned, and it is never used in any version. So change the severity to minor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiaqizho jiaqizho

Labels
affects-5.3 affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.0 severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
5 participants
@flowbehappy @JaySon-Huang @jiaqizho @SchrodingerZhu @ti-chi-bot