Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TiFlash logs #4355

Closed
4 of 6 tasks
fuzhe1989 opened this issue Mar 21, 2022 · 1 comment
Closed
4 of 6 tasks

Improve TiFlash logs #4355

fuzhe1989 opened this issue Mar 21, 2022 · 1 comment
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@fuzhe1989
Copy link
Contributor

fuzhe1989 commented Mar 21, 2022

Enhancement

  1. Rename LogWithPrefix to Logger by introducing Logger then removing LogWithPrefix.
  2. Pass identifiers (request_id, session_id, trace_id, etc.) between classes and functions.
  3. Add necessary logs through MPP path and remove useless ones.
  4. Ensure INFO logs contain enough information so we can promote the default log level to INFO.
  5. Ensure performance critical area only contain necessary logs.
  6. Remove all usages of old LOG_XXX macro and stringstream. Logger: Replace LOG_XXX with LOG_FMT_XXX #4346
@fuzhe1989 fuzhe1989 added the type/enhancement The issue or PR belongs to an enhancement. label Mar 21, 2022
@fuzhe1989 fuzhe1989 self-assigned this Mar 21, 2022
@JaySon-Huang
Copy link
Contributor

  1. Remove all usages of old LOG_XXX macro and stringstream.

Ref #4346.
@Lloyd-Pottiger is assigned to replace the old LOG_XXX with LOG_FMT_XXX. Begin with logging in the storage layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants