Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake version constraint at main repo is not correct #4138

Closed
SchrodingerZhu opened this issue Feb 25, 2022 · 0 comments · Fixed by #4162
Closed

CMake version constraint at main repo is not correct #4138

SchrodingerZhu opened this issue Feb 25, 2022 · 0 comments · Fixed by #4162
Labels
severity/minor type/bug The issue is confirmed as a bug.

Comments

@SchrodingerZhu
Copy link
Contributor

SchrodingerZhu commented Feb 25, 2022 •
edited
Loading

Bug Report

According to cmake doc, we need to update the version constraint in README to 3.21.0+

Or we can simply guard the install target with version check. It is only used in release anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chores(cmake): bump version to 3.21.0 SchrodingerZhu/tics
1 participant
@SchrodingerZhu