Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Snapshot Predecode Duration" metric doesn't take syncSchema time in to account #3759

Closed
CalvinNeo opened this issue Dec 28, 2021 · 4 comments · Fixed by #3978
Closed
Assignees
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@CalvinNeo
Copy link
Member

Bug Report

1. Minimal reproduce step (Required)

We have a scenario that involves heavy syncSchema(up to 7min) during PrehandleSnapshot.

However, there is no easy way for us to achieve this solution from metrics. The "Snapshot Predecode Duration" does not include syncSchema time(such as AtomicGetStorageSchema).

2. What did you expect to see? (Required)

There is a easy way to find out a heavy syncSchema or PrehandleSnapshot job, through metrics.

3. What did you see instead (Required)

There is no easy way.

4. What is your TiFlash version? (Required)

nightly

@CalvinNeo CalvinNeo added the type/bug The issue is confirmed as a bug. label Dec 28, 2021
@JaySon-Huang
Copy link
Contributor

What make syncSchema take 7 min?

@CalvinNeo
Copy link
Member Author

I deleted 3000 tables

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Dec 28, 2021

3000.0/(7 * 60) = 7.14. So it means dropping one table cost about 7 seconds, still too slow.
Are you dropping 3000 empty tables? However, dropping one table even containing a large amount of data takes 7 seconds still too slow. Do we have logs or can we reproduce this scenario to explore why?

@CalvinNeo
Copy link
Member Author

"Drop 3000 tables cost 7min" is a rough description, I have a doc about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants