Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support least()/greatest() in TiFlash #3358

Open
windtalker opened this issue Nov 3, 2021 · 2 comments · Fixed by #3801
Open

support least()/greatest() in TiFlash #3358

windtalker opened this issue Nov 3, 2021 · 2 comments · Fixed by #3801
Assignees
@ywqzzy
Labels
component/expression type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@windtalker
Copy link
Contributor

MySQL docs:
https://dev.mysql.com/doc/refman/8.0/en/comparison-operators.html#function_least
TiDB implementation:
https://github.com/pingcap/tidb/blob/b561dface8b0b6408bc067189cf0bcbfd5c6d617/expression/builtin_compare.go#L684
@fuzhe1989
Copy link
Contributor

@ywqzzy you can get help from @XuHuaiyu.

@ywqzzy ywqzzy mentioned this issue Jan 5, 2022
Merged
4 tasks
@guo-shaoge guo-shaoge added the type/feature-request Categorizes issue or PR as related to a new feature. label Mar 3, 2022
@guo-shaoge guo-shaoge mentioned this issue Mar 3, 2022
Closed
ti-chi-bot pushed a commit that referenced this issue Mar 3, 2022
@ywqzzy
expression: support least/greatest for int/real. (#3801)
6ed8574 
close #3358
@fuzhe1989 fuzhe1989 reopened this Mar 3, 2022
@fuzhe1989
Copy link
Contributor

reopen this issue since GREATEST/LEAST is not fully supported.

@windtalker windtalker changed the title support LEAST() in TiFlash support least()/greatest() in TiFlash Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ywqzzy ywqzzy

Labels
component/expression type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expression: support least/greatest for int/real. ywqzzy/tiflash_1
4 participants
@windtalker @fuzhe1989 @guo-shaoge @ywqzzy