Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DiagnosticsService on macOS #2682

Closed
CalvinNeo opened this issue Aug 12, 2021 · 2 comments · Fixed by #2719
Closed

Fix DiagnosticsService on macOS #2682

CalvinNeo opened this issue Aug 12, 2021 · 2 comments · Fixed by #2719
Assignees
@CalvinNeo
Labels
severity/minor type/bug The issue is confirmed as a bug.

Comments

@CalvinNeo
Copy link
Member

DiagnosticsService can't handle maxOS:

  1. Functions such like memHardwareInfo raise uncaught exceptions.
  2. macOS does not support /proc/

Also reported in https://asktug.com/t/topic/95684
@CalvinNeo CalvinNeo self-assigned this Aug 12, 2021
@CalvinNeo
Copy link
Member Author

Seems sysctl is a way out

@CalvinNeo CalvinNeo mentioned this issue Aug 18, 2021
Merged
@SchrodingerZhu
Copy link
Contributor

@CalvinNeo see also https://github.com/pingcap/tics/blob/484d9ef9bb177dd2e2cf091b1d7def3094a6742c/libs/libcommon/include/common/simd.h#L77

@lilinghai lilinghai added type/bug The issue is confirmed as a bug. severity/minor labels Sep 7, 2021
@solotzg solotzg mentioned this issue Mar 23, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 23, 2022
@solotzg
Clean useless code in dbms/src/Flash/DiagnosticsService.cpp (#4401)
303950f 
ref #2682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CalvinNeo CalvinNeo

Labels
severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

read server_info from proxy through ffi CalvinNeo/tiflash
3 participants
@CalvinNeo @lilinghai @SchrodingerZhu