Fix data race of DeltaIndex::toString (#5948) (#5954)

close #5947
pingcap · Oct 10, 2022 · ca39013 · ca39013
1 parent 7668a60
commit ca39013
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/dbms/src/Storages/DeltaMerge/DeltaIndex.h b/dbms/src/Storages/DeltaMerge/DeltaIndex.h
@@ -145,10 +145,13 @@ class DeltaIndex
 
     String toString()
     {
-        std::stringstream s;
-        s << "{placed rows:" << placed_rows << ", deletes:" << placed_deletes << ", delta tree: " << delta_tree->numEntries() << "|"
-          << delta_tree->numInserts() << "|" << delta_tree->numDeletes() << "}";
-        return s.str();
+        std::scoped_lock lock(mutex);
+        return fmt::format("<placed_rows={} placed_deletes={} tree_entries={} tree_inserts={} tree_deletes={}>",
+                           placed_rows,
+                           placed_deletes,
+                           delta_tree->numEntries(),
+                           delta_tree->numInserts(),
+                           delta_tree->numDeletes());
     }
 
     UInt64 getId() const { return id; }