Fix bug that copy ExpressionActionsChain's last step by value, not by…

… reference. (#3487)
pingcap · Nov 20, 2021 · c3c0bb7 · c3c0bb7
1 parent e655a42
commit c3c0bb7
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp b/dbms/src/Flash/Coprocessor/DAGExpressionAnalyzer.cpp
@@ -1132,7 +1132,7 @@ void DAGExpressionAnalyzer::appendAggSelect(ExpressionActionsChain & chain, cons
     initChain(chain, getCurrentInputColumns());
     bool need_update_aggregated_columns = false;
     std::vector<NameAndTypePair> updated_aggregated_columns;
-    ExpressionActionsChain::Step step = chain.steps.back();
+    ExpressionActionsChain::Step & step = chain.steps.back();
     for (Int32 i = 0; i < aggregation.agg_func_size(); i++)
     {
         String & name = aggregated_columns[i].name;
@@ -1236,7 +1236,7 @@ NamesWithAliases DAGExpressionAnalyzer::appendFinalProject(
         /// for all the columns that need to be returned, if the type is timestamp, then convert
         /// the timestamp column to UTC based, refer to appendTimeZoneCastsAfterTS for more details
         initChain(chain, getCurrentInputColumns());
-        ExpressionActionsChain::Step step = chain.steps.back();
+        ExpressionActionsChain::Step & step = chain.steps.back();
 
         tipb::Expr tz_expr;
         constructTZExpr(tz_expr, context.getTimezoneInfo(), false);