Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/master' into new-proxy-tikv-se…
Browse files Browse the repository at this point in the history
…rver
  • Loading branch information
CalvinNeo committed Jul 12, 2022
2 parents 389badd + 34d7570 commit 8443892
Show file tree
Hide file tree
Showing 67 changed files with 2,460 additions and 958 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/license-checker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: Check License Header
uses: apache/skywalking-eyes@main
uses: apache/skywalking-eyes@v0.3.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand Down
6 changes: 2 additions & 4 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -239,10 +239,8 @@ else ()
set (CMAKE_CXX_STANDARD_REQUIRED ON)
endif ()

if (NOT ARCH_ARM)
set (CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS_RELWITHDEBINFO} -O3")
set (CMAKE_C_FLAGS_RELWITHDEBINFO "${CMAKE_C_FLAGS_RELWITHDEBINFO} -O3")
endif ()
set (CMAKE_CXX_FLAGS_RELWITHDEBINFO "${CMAKE_CXX_FLAGS_RELWITHDEBINFO} -O3")
set (CMAKE_C_FLAGS_RELWITHDEBINFO "${CMAKE_C_FLAGS_RELWITHDEBINFO} -O3")

option (DEBUG_WITHOUT_DEBUG_INFO "Set to ON to build dev target without debug info (remove flag `-g` in order to accelerate compiling speed and reduce target binary size)" OFF)
if (DEBUG_WITHOUT_DEBUG_INFO)
Expand Down
2 changes: 1 addition & 1 deletion contrib/tipb
6 changes: 6 additions & 0 deletions dbms/src/Common/MPMCQueue.h
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#pragma once

#include <Common/SimpleIntrusiveNode.h>
#include <Common/nocopyable.h>
#include <common/defines.h>
#include <common/types.h>

Expand Down Expand Up @@ -74,6 +75,11 @@ class MPMCQueue
destruct(getObj(read_pos));
}

// Cannot to use copy/move constructor,
// because MPMCQueue maybe used by different threads.
// Copy and move it is dangerous.
DISALLOW_COPY_AND_MOVE(MPMCQueue);

/// Block until:
/// 1. Pop succeeds with a valid T: return true.
/// 2. The queue is cancelled or finished: return false.
Expand Down
7 changes: 3 additions & 4 deletions dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace DB
{
ParallelAggregatingBlockInputStream::ParallelAggregatingBlockInputStream(
const BlockInputStreams & inputs,
const BlockInputStreamPtr & additional_input_at_end,
const BlockInputStreams & additional_inputs_at_end,
const Aggregator::Params & params_,
const FileProviderPtr & file_provider_,
bool final_,
Expand All @@ -41,11 +41,10 @@ ParallelAggregatingBlockInputStream::ParallelAggregatingBlockInputStream(
, keys_size(params.keys_size)
, aggregates_size(params.aggregates_size)
, handler(*this)
, processor(inputs, additional_input_at_end, max_threads, handler, log)
, processor(inputs, additional_inputs_at_end, max_threads, handler, log)
{
children = inputs;
if (additional_input_at_end)
children.push_back(additional_input_at_end);
children.insert(children.end(), additional_inputs_at_end.begin(), additional_inputs_at_end.end());
}


Expand Down
2 changes: 1 addition & 1 deletion dbms/src/DataStreams/ParallelAggregatingBlockInputStream.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class ParallelAggregatingBlockInputStream : public IProfilingBlockInputStream
*/
ParallelAggregatingBlockInputStream(
const BlockInputStreams & inputs,
const BlockInputStreamPtr & additional_input_at_end,
const BlockInputStreams & additional_inputs_at_end,
const Aggregator::Params & params_,
const FileProviderPtr & file_provider_,
bool final_,
Expand Down
Loading

0 comments on commit 8443892

Please sign in to comment.