fix static analysis

dbms/src/Storages/DeltaMerge/Segment.cpp

@@ -88,7 +88,7 @@ DMFilePtr writeIntoNewDMFile(DMContext & dm_context, //
 {
     auto dmfile = DMFile::create(file_id, parent_path, flags.isSingleFile(), dm_context.createChecksumConfig(flags.isSingleFile()));
     auto output_stream = std::make_shared<DMFileBlockOutputStream>(dm_context.db_context, dmfile, *schema_snap, flags);
-    auto * mvcc_stream = typeid_cast<const DMVersionFilterBlockInputStream<DM_VERSION_FILTER_MODE_COMPACT> *>(input_stream.get());
+    const auto * mvcc_stream = typeid_cast<const DMVersionFilterBlockInputStream<DM_VERSION_FILTER_MODE_COMPACT> *>(input_stream.get());
 
     input_stream->readPrefix();
     output_stream->writePrefix();
@@ -672,7 +672,7 @@ std::optional<RowKeyValue> Segment::getSplitPointFast(DMContext & dm_context, co
 
     size_t split_row_index = stable_rows / 2;
 
-    auto & dmfiles = stable_snap->getDMFiles();
+    const auto & dmfiles = stable_snap->getDMFiles();
 
     DMFilePtr read_file;
     size_t file_index = 0;
@@ -682,13 +682,13 @@ std::optional<RowKeyValue> Segment::getSplitPointFast(DMContext & dm_context, co
     size_t cur_rows = 0;
     for (size_t index = 0; index < dmfiles.size(); index++)
     {
-        auto & file = dmfiles[index];
+        const auto & file = dmfiles[index];
         size_t rows_in_file = file->getRows();
         cur_rows += rows_in_file;
         if (cur_rows > split_row_index)
         {
             cur_rows -= rows_in_file;
-            auto & pack_stats = file->getPackStats();
+            const auto & pack_stats = file->getPackStats();
             for (size_t pack_id = 0; pack_id < pack_stats.size(); ++pack_id)
             {
                 cur_rows += pack_stats[pack_id].rows;
@@ -752,7 +752,7 @@ std::optional<RowKeyValue> Segment::getSplitPointSlow(
 {
     EventRecorder recorder(ProfileEvents::DMSegmentGetSplitPoint, ProfileEvents::DMSegmentGetSplitPointNS);
 
-    auto & pk_col = getExtraHandleColumnDefine(is_common_handle);
+    const auto & pk_col = getExtraHandleColumnDefine(is_common_handle);
     auto pk_col_defs = std::make_shared<ColumnDefines>(ColumnDefines{pk_col});
     // We need to create a new delta_reader here, because the one in read_info is used to read columns other than PK column.
     auto delta_reader = read_info.getDeltaReader(pk_col_defs);
@@ -885,13 +885,15 @@ std::optional<Segment::SplitInfo> Segment::prepareSplitLogical(DMContext & dm_co
         return {};
     }
 
-    GenPageId log_gen_page_id = std::bind(&StoragePool::newLogPageId, &storage_pool);
+    GenPageId log_gen_page_id = [&]() {
+        return storage_pool.newLogPageId();
+    };
 
     DMFiles my_stable_files;
     DMFiles other_stable_files;
 
     auto delegate = dm_context.path_pool.getStableDiskDelegator();
-    for (auto & dmfile : segment_snap->stable->getDMFiles())
+    for (const auto & dmfile : segment_snap->stable->getDMFiles())
     {
         auto ori_ref_id = dmfile->refId();
         auto file_id = dmfile->fileId();
@@ -1027,7 +1029,7 @@ std::optional<Segment::SplitInfo> Segment::prepareSplitPhysical(DMContext & dm_c
     LOG_INFO(log, "prepare other_stable done");
 
     // Remove old stable's files.
-    for (auto & file : stable->getDMFiles())
+    for (const auto & file : stable->getDMFiles())
     {
         // Here we should remove the ref id instead of file_id.
         // Because a dmfile could be used by several segments, and only after all ref_ids are removed, then the file_id removed.
@@ -1158,7 +1160,7 @@ StableValueSpacePtr Segment::prepareMerge(DMContext & dm_context, //
         throw Exception("The ranges of merge segments are not consecutive: first end: " + left->rowkey_range.getEnd().toDebugString()
                         + ", second start: " + right->rowkey_range.getStart().toDebugString());
 
-    auto getStream = [&](const SegmentPtr & segment, const SegmentSnapshotPtr & segment_snap) {
+    auto get_stream = [&](const SegmentPtr & segment, const SegmentSnapshotPtr & segment_snap) {
         auto read_info = segment->getReadInfo(
             dm_context,
             *schema_snap,
@@ -1186,8 +1188,8 @@ StableValueSpacePtr Segment::prepareMerge(DMContext & dm_context, //
         return stream;
     };
 
-    auto left_stream = getStream(left, left_snap);
-    auto right_stream = getStream(right, right_snap);
+    auto left_stream = get_stream(left, left_snap);
+    auto right_stream = get_stream(right, right_snap);
 
     BlockInputStreamPtr merged_stream = std::make_shared<ConcatBlockInputStream>(BlockInputStreams{left_stream, right_stream}, nullptr);
     // for the purpose to calculate StableProperty of the new segment