remove unnecessary change

pingcap · Jun 27, 2022 · 032738e · 032738e
1 parent 912728d
commit 032738e
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/dbms/src/Storages/Transaction/RegionCFDataBase.cpp b/dbms/src/Storages/Transaction/RegionCFDataBase.cpp
@@ -77,14 +77,6 @@ size_t RegionCFDataBase<Trait>::calcTiKVKeyValueSize(const Value & value)
     return calcTiKVKeyValueSize(getTiKVKey(value), *getTiKVValuePtr(value));
 }
 
-template <>
-size_t RegionCFDataBase<RegionLockCFDataTrait>::calcTiKVKeyValueSize(const Value & value)
-{
-    std::ignore = value;
-    return 0;
-    return calcTiKVKeyValueSize(getTiKVKey(value), *getTiKVValuePtr(value));
-}
-
 template <typename Trait>
 size_t RegionCFDataBase<Trait>::calcTiKVKeyValueSize(const TiKVKey & key, const TiKVValue & value)
 {
@@ -275,11 +267,10 @@ template struct RegionCFDataBase<RegionLockCFDataTrait>;
 namespace RecordKVFormat
 {
 // https://github.com/tikv/tikv/blob/master/components/txn_types/src/lock.rs
-inline std::pair<size_t, size_t> decodeLockCfValue(DecodedLockCFValue & res, std::shared_ptr<const TiKVValue> & value)
+inline void decodeLockCfValue(DecodedLockCFValue & res, std::shared_ptr<const TiKVValue> & value)
 {
     const char * data = value->data();
-    size_t total_size = value->dataSize();
-    size_t len = total_size;
+    size_t len = value->dataSize();
 
     kvrpcpb::Op lock_type = kvrpcpb::Op_MIN;
     switch (readUInt8(data, len))
@@ -365,7 +356,6 @@ inline std::pair<size_t, size_t> decodeLockCfValue(DecodedLockCFValue & res, std
         if (len != 0)
             throw Exception("invalid lock value " + value->toDebugString(), ErrorCodes::LOGICAL_ERROR);
     }
-    return std::make_pair(0, 0);
 }
 
 DecodedLockCFValue::DecodedLockCFValue(std::shared_ptr<const TiKVKey> & key_, std::shared_ptr<const TiKVValue> & val_)