expression: fix issue that results of unix_timestamp()-unix_timestamp(now()) is wrong and not stable
#9884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
winoros
reviewed
Mar 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #9884 +/- ##
================================================
- Coverage 77.4806% 77.2959% -0.1847%
================================================
Files 404 404
Lines 81663 81655 -8
================================================
- Hits 63273 63116 -157
- Misses 13679 13854 +175
+ Partials 4711 4685 -26 |
zz-jason
reviewed
Mar 28, 2019
| @@ -3371,7 +3371,7 @@ func (s *testSuite3) TestCurrentTimestampValueSelection(c *C) { | |||
| tk.MustQuery("select id from t where t0 = ?", t0).Check(testkit.Rows("1")) | |||
| tk.MustQuery("select id from t where t1 = ?", t1).Check(testkit.Rows("1")) | |||
| tk.MustQuery("select id from t where t2 = ?", t2).Check(testkit.Rows("1")) | |||
| time.Sleep(time.Second / 2) | |||
There was a problem hiding this comment.
There are two calls of now() around this sleep().
One is used to insert a record t0=now() and the other is used to update it set t0=now().
Before this PR, since now() rounds the result, so we can assume that these two calls of now() must get two time with different seconds and the update operation really happens.
After this PR, this assumption is broken, so I increase the waiting time to ensure they can get two time with different seconds.
XuHuaiyu
added
status/LGT2
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
qw4990
changed the title
unix_timestamp()-unix_timestamp(now()) is wrong and not stableunix_timestamp()-unix_timestamp(now()) is wrong and not stable
|
/run-all-tests |
XuHuaiyu
changed the title
unix_timestamp()-unix_timestamp(now()) is wrong and not stableunix_timestamp()-unix_timestamp(now()) is wrong and not stable
XuHuaiyu
approved these changes
Mar 29, 2019
|
/run-all-tests |
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
May 15, 2019
…p(now())` is wrong and not stable (pingcap#9884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9710
In MySQL,
Now()andUnixTimestamp()will truncate the result while they will round the result in TiDB.These results below from MySQL 5.7 can prove it.
What is changed and how it works?
Let
Now()andUnixTimestamp()truncate the result instead of rounding it.Check List
Tests