-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]expression: support ValidatePasswordStrength() #9812
Conversation
@wjhuang2016 Thanks for your PR! |
Codecov Report
@@ Coverage Diff @@
## master #9812 +/- ##
================================================
- Coverage 81.5133% 81.3482% -0.1652%
================================================
Files 434 424 -10
Lines 93765 90919 -2846
================================================
- Hits 76431 73961 -2470
+ Misses 11881 11634 -247
+ Partials 5453 5324 -129 |
Thank you for working on this! It is the last missing function on this list, so I am excited to see it get merged. |
@wjhuang2016 please resolve conflicts. Thank you! |
5c0e8db
to
d585e66
Compare
9e35f35
to
1d56844
Compare
Friendly ping @wjhuang2016 and please resolve conflicts 🤣. |
Already solved |
Hi, @wjhuang2016 |
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
Hi, @wjhuang2016 |
LGTM |
PTAL @zz-jason |
This PR is WIP, there are some corner cases to deal with. |
Hi @wjhuang2016 , do you have any plan to continue developing this feature? |
What problem does this PR solve?
Support ValidatePasswordStrength() except checking by a dictionary file, See #9741 or #2632
What is changed and how it works?
Accroding to https://dev.mysql.com/doc/refman/8.0/en/validate-password-options-variables.html
and https://dev.mysql.com/doc/refman/8.0/en/encryption-functions.html#function_validate-password-strength, we need to check the password strength by
user
、auth_user
、length
、mixed_case_count
、number_count
、special_char_count
, even a dictionary file.Presently I check the above conditions except dictionary file, and I'm not sure whether we can read a file directly in a distributed environment.
In MySQL, a user can decide whether to use
validate_password
component. If we apply thevalide_password
before setting a password, we may need a option for user to decide whether to checkpassword by
valide_password
.Check List
Tests
Code changes
Side effects
Related changes