Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: support window function nth_value #9596

Merged
merged 8 commits into from
Mar 11, 2019
Merged

executor: support window function nth_value #9596

merged 8 commits into from
Mar 11, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Mar 7, 2019

What problem does this PR solve?

Support window function nth_value. Refer https://dev.mysql.com/doc/refman/8.0/en/window-function-descriptions.html#function_nth-value

For #9499

What is changed and how it works?

Implement the nth_value under the aggregation interface.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • None

@alivxxx alivxxx added type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution labels Mar 7, 2019
@alivxxx alivxxx mentioned this pull request Mar 7, 2019
Closed
11 tasks
@codecov-io
Copy link

codecov-io commented Mar 7, 2019 •
edited by codecov bot
Loading

Codecov Report

Merging #9596 into master will decrease coverage by 0.0581%.
The diff coverage is 9.375%.

@@               Coverage Diff                @@
##             master      #9596        +/-   ##
================================================
- Coverage   67.4347%   67.3765%   -0.0582%     
================================================
  Files           376        376                
  Lines         79201      79262        +61     
================================================
- Hits          53409      53404         -5     
- Misses        21023      21087        +64     
- Partials       4769       4771         +2

zz-jason
zz-jason reviewed Mar 7, 2019
View reviewed changes
expression/util.go Show resolved Hide resolved
expression/util.go Show resolved Hide resolved
zz-jason
zz-jason reviewed Mar 9, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 9, 2019
@alivxxx
Copy link
Contributor Author

alivxxx commented Mar 11, 2019

/run-all-tests

@alivxxx
Copy link
Contributor Author

alivxxx commented Mar 11, 2019

/run-integration-common-test

qw4990
qw4990 previously approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2019
@zz-jason zz-jason merged commit 6e8cd3c into pingcap:master Mar 11, 2019
@alivxxx alivxxx deleted the nth branch May 23, 2019 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@qw4990 qw4990 qw4990 left review comments

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alivxxx @codecov-io @zz-jason @qw4990 @zhouqiang-cl