ddl: fix create table with like bug when refer table has non-public column/index #9580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9580 +/- ##
===============================================
+ Coverage 67.4097% 67.415% +0.0053%
===============================================
Files 376 376
Lines 79180 79190 +10
===============================================
+ Hits 53375 53386 +11
+ Misses 21034 21032 -2
- Partials 4771 4772 +1 |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
zimulala
reviewed
Mar 7, 2019
zimulala
reviewed
Mar 7, 2019
zimulala
reviewed
Mar 7, 2019
|
/run-all-tests |
…/tidb into fix-create-table-like
zimulala
reviewed
Mar 8, 2019
zimulala
added
status/LGT2
xiekeyi98
reviewed
Mar 11, 2019
xiekeyi98
added
status/LGT3
|
/run-all-tests |
|
Please cherry-pick to 2.1, 2.0 |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Mar 11, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Mar 11, 2019
winkyao
pushed a commit
that referenced
this pull request
Mar 12, 2019
winkyao
pushed a commit
that referenced
this pull request
Mar 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Create table with like will copy refer table directly, It will have problem when refer table have a non-public column or index( may cause by add/drop column/index ). That will cause the new create table will have a column/index always in non-public, this may cause some problem. See jira issue#3190.
What is changed and how it works?
Check non-public column and index when create table with like.
Check List
Tests
Code changes
Side effects
Related changes