Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: return null when cast to huge binary type (#8768) #9349

Merged
merged 1 commit into from
Feb 19, 2019
Merged

expression: return null when cast to huge binary type (#8768) #9349

merged 1 commit into from
Feb 19, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #8768

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. component/expression type/2.1 cherry-pick labels Feb 19, 2019
@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

alivxxx
alivxxx reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zimulala
zimulala approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 19, 2019
@zimulala zimulala merged commit 5fe4c27 into pingcap:release-2.1 Feb 19, 2019
@eurekaka eurekaka deleted the cast_binary_21 branch February 19, 2019 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@zimulala zimulala zimulala approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eurekaka @zimulala @alivxxx