Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner, privileges: add CreateViewPriv Support #9153

Merged
merged 13 commits into from
Feb 15, 2019
Merged

planner, privileges: add CreateViewPriv Support #9153

merged 13 commits into from
Feb 15, 2019

Conversation

AndrewDi
Copy link
Contributor

What problem does this PR solve?

Implement CreateViewPriv check when create a view

What is changed and how it works?

ref proposal Proposal: Implement View

Check List

Tests

  • Unit test

@AndrewDi AndrewDi mentioned this pull request Jan 22, 2019
Closed
19 tasks
@AndrewDi AndrewDi changed the title Add CreateViewPriv Support planbuilder,privileges: add CreateViewPriv Support Jan 22, 2019
@AndrewDi AndrewDi mentioned this pull request Jan 22, 2019
Merged
tiancaiamao
tiancaiamao reviewed Jan 23, 2019
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@AndrewDi
Copy link
Contributor Author

@tiancaiamao @XuHuaiyu PTAL

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 29, 2019
@tiancaiamao
Copy link
Contributor

Parser has been merged, so you can update this PR now.

@AndrewDi
Copy link
Contributor Author

/run-all-tests

@codecov-io
Copy link

codecov-io commented Jan 29, 2019 •
edited
Loading

Codecov Report

Merging #9153 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9153      +/-   ##
=========================================
+ Coverage    67.2%   67.2%   +<.01%     
=========================================
  Files         371     371              
  Lines       77552   77552              
=========================================
+ Hits        52115   52120       +5     
+ Misses      20781   20778       -3     
+ Partials     4656    4654       -2
Impacted Files Coverage Δ
planner/core/planbuilder.go 49.59% <100%> (ø) ⬆️
privilege/privileges/cache.go 77.47% <100%> (ø) ⬆️
store/tikv/lock_resolver.go 41.7% <0%> (-0.95%) ⬇️
util/filesort/filesort.go 76.17% <0%> (-0.32%) ⬇️
executor/join.go 78.38% <0%> (+0.52%) ⬆️
expression/schema.go 94.53% <0%> (+0.78%) ⬆️
infoschema/infoschema.go 77.63% <0%> (+1.31%) ⬆️
util/systimemon/systime_mon.go 100% <0%> (+20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6136ab1...a93d917. Read the comment docs.

@tiancaiamao
Copy link
Contributor

PTAL @XuHuaiyu

@tiancaiamao
Copy link
Contributor

PTAL @XuHuaiyu
pingcap/parser#138 is merged, if we don't merge this one, the CI of parser would fail.

@AndrewDi
Copy link
Contributor Author

@XuHuaiyu @zz-jason PTAL

@AndrewDi
Copy link
Contributor Author

/run-all-tests

zz-jason
zz-jason approved these changes Feb 15, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason changed the title planbuilder,privileges: add CreateViewPriv Support planner, privileges: add CreateViewPriv Support Feb 15, 2019
@zz-jason zz-jason added component/privilege status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 15, 2019
@zz-jason zz-jason merged commit d09e0e3 into pingcap:master Feb 15, 2019
@AndrewDi AndrewDi deleted the view/add_view_priv branch March 11, 2019 12:29
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/privilege contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AndrewDi @tiancaiamao @codecov-io @zz-jason @sre-bot