-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* fix timestamp default value bug in multiple time zones. #9115
* fix timestamp default value bug in multiple time zones. #9115
Conversation
/run-all-tests |
1 similar comment
/run-all-tests |
/run-all-tests |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reset LGTM
/run-all-tests |
@XuHuaiyu PTAL |
…mp-default-value-zone
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@crazycs520 Is this PR ready to be merged? |
What problem does this PR solve?
Fix timestamp default value bug in multiple time zones.
TiDB
mysql
Related Parser PR:pingcap/parser#183
releated Issue: #9064
What is changed and how it works?
Old tidb save timestamp default value without convert to UTC time. Then if TiDB in multiple timezone, and use the default value of timestamp will have different result problem.
This PR will save timestamp default value in UTC time.
And add a
version
field to solve compatible problem.Check List
Tests
Code changes
Side effects
Related changes