-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plan/executor: handle optimizer hint properly for cartesian join #9037
Conversation
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-unit-test |
Comments addressed, @XuHuaiyu PTAL |
Codecov Report
@@ Coverage Diff @@
## master #9037 +/- ##
==========================================
- Coverage 67.28% 67.26% -0.03%
==========================================
Files 371 371
Lines 75930 75920 -10
==========================================
- Hits 51092 51070 -22
- Misses 20332 20346 +14
+ Partials 4506 4504 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Fix #9032
What is changed and how it works?
Check List
Tests
Code changes
N/A
Side effects
N/A
Related changes